Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network Edge Events Published #12

Closed
wants to merge 5 commits into from
Closed

Network Edge Events Published #12

wants to merge 5 commits into from

Conversation

shyamchalla
Copy link
Contributor

No description provided.

Copy link
Contributor

@ryli17 ryli17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revise code as Tim mentioned.

@shyamchalla shyamchalla requested review from a team as code owners January 8, 2025 19:19
Comment on lines -159 to +170
"released": [],
"released": [
"equinix.network_edge.acl.state.created",
"equinix.network_edge.acl.state.deleted",
"equinix.network_edge.device.acl.updated",
"equinix.network_edge.device.reboot.completed",
"equinix.network_edge.device.reboot.started",
"equinix.network_edge.device.state.cancelled",
"equinix.network_edge.device.state.created",
"equinix.network_edge.device.state.deleted",
"equinix.network_edge.device.state.provisioned",
"equinix.network_edge.device.state.provisioning"
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't change DataLoader.json, catalog.json, and README.md manually. They will be generated automatically. Please make sure the github actions succeeded.l

"released": [
{
"name": "equinix.network_edge.device.state.created",
"description": ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add all descriptions. It can be similar to the corresponding message. The PR #17 has those values empty for placeholder purpose. We are working to add descriptions, as well.

@jonawong
Copy link

jonawong commented Jan 9, 2025

Hi do we have an ETA on this? We will need to get this out as soon as possible.

@shyamchalla shyamchalla closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants